Skip to content

Typescript conversion#112

Closed
Rlin232 wants to merge 15 commits intomasterfrom
typescript-conversion
Closed

Typescript conversion#112
Rlin232 wants to merge 15 commits intomasterfrom
typescript-conversion

Conversation

@Rlin232
Copy link
Copy Markdown
Contributor

@Rlin232 Rlin232 commented Aug 13, 2021

Steps required for this to be released:

  • Add a deprecation message for the ruby version
  • Update Dockerfile to work with the javascript version
  • Create npx package from this repository
  • Setup Github actions to automatically release new javascript package just as we do now for the ruby package
  • Update the README to include npx and Docker usage of the new package
  • Release final version of Heimdall Tools with the deprecation warning
    - [ ] Merge this branch into master and release the javascript version of the package

@Rlin232
Copy link
Copy Markdown
Contributor Author

Rlin232 commented Aug 13, 2021

Blocked by: mitre/heimdall2#1794

AwsConfigMapper is not yet merged into release (possible testing required for socket timeout and throttling exceptions)

  • Doing (179x2 + 1) number of requests over a short time leads me to believe that I'm running into rate limiting

Potentially blocked by: Sonarqube mapper not being written

@jkufro
Copy link
Copy Markdown
Contributor

jkufro commented Sep 27, 2021

Blocked by: mitre/heimdall2#1784

ASFFMapper (+extensions) is not merged into release

Blocked by: mitre/heimdall2#1794

AwsConfigMapper is not yet merged into release (possible testing required for socket timeout and throttling exceptions)

  • Doing (179x2 + 1) number of requests over a short time leads me to believe that I'm running into rate limiting

Potentially blocked by: Sonarqube mapper not being written

I have run into rate limiting on the ruby version and a fix for me was to add a 0.5 second wait after each API call that uses a nextToken

@rbclark rbclark assigned Rlin232 and unassigned Amndeep7, georgedias and camdenmoors Nov 3, 2021
Rlin232 and others added 9 commits November 10, 2021 08:32
Signed-off-by: Rlin232 <38306648+Rlin232@users.noreply.github.com>
Signed-off-by: Rlin232 <38306648+Rlin232@users.noreply.github.com>
Signed-off-by: Rlin232 <38306648+Rlin232@users.noreply.github.com>
Signed-off-by: Rlin232 <38306648+Rlin232@users.noreply.github.com>
Signed-off-by: Rlin232 <38306648+Rlin232@users.noreply.github.com>
@camdenmoors
Copy link
Copy Markdown
Contributor

This is now the SAF CLI https://github.com/mitre/saf

@camdenmoors camdenmoors closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants