Make MLflow port configurable and prevent killing non-MLflow processes#14
Open
deacon-mp wants to merge 1 commit into
Open
Make MLflow port configurable and prevent killing non-MLflow processes#14deacon-mp wants to merge 1 commit into
deacon-mp wants to merge 1 commit into
Conversation
The hook.py kill_existing_mlflow() function previously killed any process on port 5000 without verifying it was MLflow. This change: - Checks process cmdline contains 'mlflow' before killing - Makes the port configurable via MCP_MLFLOW_PORT env var - Replaces hardcoded port references with the configurable value Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kill_existing_mlflow()now checks that a process's command line contains "mlflow" before killing it, instead of blindly killing any process on the port.MCP_MLFLOW_PORTenvironment variable (default: 5000), replacing all hardcoded5000references.print()calls withlog.info()/log.warning()for proper log integration.Test plan
MCP_MLFLOW_PORT=5001and verify MLflow starts on port 5001🤖 Generated with Claude Code