Skip to content

Fix bug in VectorClock example#52

Open
stuartsan wants to merge 1 commit into
mixu:masterfrom
stuartsan:patch-1
Open

Fix bug in VectorClock example#52
stuartsan wants to merge 1 commit into
mixu:masterfrom
stuartsan:patch-1

Conversation

@stuartsan
Copy link
Copy Markdown

@stuartsan stuartsan commented May 26, 2019

Great book, thanks for writing it!

I think there's a bug in the merge method in the VectorClock example; as-is the result of the concatenation will be something like:

['foo', 'bar', { 'foo': 1, 'bar': 2 }]

And I believe it should be more like:

['foo', 'bar', 'foo', 'bar']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant