Skip to content

find_by_headers returned wrong table when using nested tables#3

Open
sintemal wants to merge 1 commit into
mk12:mainfrom
sintemal:main
Open

find_by_headers returned wrong table when using nested tables#3
sintemal wants to merge 1 commit into
mk12:mainfrom
sintemal:main

Conversation

@sintemal
Copy link
Copy Markdown

find_by_headers would stop to early when scanning for headers, as it would treat headers of nested tables as headers of the top table

@sintemal
Copy link
Copy Markdown
Author

ping

@mk12
Copy link
Copy Markdown
Owner

mk12 commented Feb 7, 2023

Sorry, I'm not sure why I never saw this. Mentioning me (@mk12) might be more reliable.

I'm willing to merge this fix with two changes:

  • It should be possible to do it directly with CSS selectors. I think :scope > th instead of th would be sufficient. If that doesn't work, there's probably some way to refactor it to use tr > th.
  • It needs a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants