84 possible refactor#92
Draft
AymanBx wants to merge 16 commits into
Draft
Conversation
AymanBx
commented
Jun 10, 2026
AymanBx
commented
Contributor
- Runner has run method that is called by task
- Bench objects has list of runners in its attributes
- Run method in Bench will loop for each runner
- Bench load methods will utilize runner yaml files now
- Added demo files to demonstrate the new changes
…rse which is high-level and has more potential
…unners loaded from yml files
brownsarahm
requested changes
Jun 24, 2026
| @@ -1,4 +1,4 @@ | |||
| runner_type: ollama | |||
| model: | |||
| models: | |||
Contributor
There was a problem hiding this comment.
enable specifying the parameters under here
Contributor
There was a problem hiding this comment.
combine this with runnery.yml under 'model_params' key and then pass that whole sub-dictionary to the model
| for task_dict in task_list: | ||
| tasks.append(Task.from_dict(task_dict,source_path=benchmark_path)) | ||
|
|
||
| runners = Bench.load_runners(benchmark_path) |
Contributor
There was a problem hiding this comment.
call the from_file on benchlist instead and in the bench constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.