fix: extract flowcell ID, handle backslash paths, support 6-digit dates#81
Merged
fix: extract flowcell ID, handle backslash paths, support 6-digit dates#81
Conversation
- Extract actual flowcell ID using nemo's regex (000000000-AGKG7 → AGKG7) - Normalize backslashes so basename() works with Windows paths on Linux - Support 6-digit dates (ymd format, e.g. 151231) alongside 8-digit (Ymd) - Use Carbon instead of CarbonImmutable (aligns with #80) - Remove unused toString() and rawFlowcellSegment (YAGNI) - Add comprehensive test coverage for all Illumina run folder formats Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simbig
force-pushed
the
fix-illumina-run-folder
branch
from
d51e168 to
2d14332
Compare
Tests already document all format variants — no need to repeat examples in docblocks. Remove internal GitLab reference. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simbig
force-pushed
the
fix-illumina-run-folder
branch
from
fb14f16 to
4af0d77
Compare
KingKong1213
approved these changes
Mar 11, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
## [6.5.1](v6.5.0...v6.5.1) (2026-03-11) ### Bug Fixes * extract flowcell ID, handle backslash paths, support 6-digit dates ([#81](#81)) ([830068d](830068d))
|
🎉 This PR is included in version 6.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
IlluminaRunFolderfrom v6.5.0 to correctly handle real-world Illumina run folder formats:000000000-AGKG7→AGKG7)basename()doesn't recognize\as separator on Linuxymdformat (e.g.151231)Carboninstead ofCarbonImmutable— aligns with feat!: banCarbonImmutablevia PHPStan #80toString()andrawFlowcellSegment— no consumer, unclear semantics (YAGNI)Test plan
🤖 Generated with Claude Code