handle invalid UTF-8 more cleanly - replacement character#18
Open
slippycheeze wants to merge 1 commit intomlsmithjr:masterfrom
Open
handle invalid UTF-8 more cleanly - replacement character#18slippycheeze wants to merge 1 commit intomlsmithjr:masterfrom
slippycheeze wants to merge 1 commit intomlsmithjr:masterfrom
Conversation
This updates the UTF-8 decoding in pytranscoder to treat non-UTF-8 output without error: it replaces invalid characters with the Unicode `REPLACEMENT CHARACTER` `U+FFFD`. These characters only occur in "user"-supplied metadata in media, such as title, series, or encoder tags, so there is little to no risk of loss of any useful information in the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the UTF-8 decoding in pytranscoder to treat non-UTF-8
output without error: it replaces invalid characters with the Unicode
REPLACEMENT CHARACTERU+FFFD.These characters only occur in "user"-supplied metadata in media, such
as title, series, or encoder tags, so there is little to no risk of loss
of any useful information in the change.