fix escaping issues for streaming hosts#20
Open
LarsNt wants to merge 3 commits intomlsmithjr:masterfrom
Open
Conversation
* quote paths in processor arguments * scp command would fail with spaces (or other special characters) in path or filename * double quotes still pose a problem but are less likely to occure * '-T' option for scp needed since strict filename checking doesn't work with quoted paths (might cause problems with pre Jan 2019 ssh/scp Versions)
* add option remote_copy_cmd - string values starting with '[' are evaluated as python lists - other values are split by whitespaces into argument list * add example and description in Cluser.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some issues to get the streaming host configuration in cluster mode to work. This might also relate to issue #8.
The main problem was that the arguments for the remote host need to be escaped or quoted for the remote shell.
The fix for the ffmpeg/hbcli call was taken from the mounted host section.
Additional fixes for the copy commands needed to be added.
Since early 2019 openssh has introduced strict filename checking which breaks with quoted filenames when we try to copy back the finished transcode.
This can be avoided by specifying the
-Toption. This again might break on systems with an ssh/scp version that doesn't have this option.Thus I added an configuration option to set the copy command.
This also allows to use other tools like rsync (see description in Cluster.md).
I have tested the code on Linux systems but not on Windows.