Changed calculation of filter_threshold so thresholds >100 don't error #3
Open
vpatel9202 wants to merge 3 commits intomlsmithjr:masterfrom
vpatel9202:master
Open
Changed calculation of filter_threshold so thresholds >100 don't error #3vpatel9202 wants to merge 3 commits intomlsmithjr:masterfrom vpatel9202:master
vpatel9202 wants to merge 3 commits intomlsmithjr:masterfrom
vpatel9202:master
Conversation
Since it's not always necessary that resulting transcode have a smaller size, changed the way this function works so you can set threshold higher than 100%. Previously, putting something like 150% would result in early termination of the transcode because it required the new file to be smaller than the old file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's not always necessary that resulting transcode have a smaller size, changed the way this function works so you can set threshold higher than 100%. Previously, putting something like 150% would result in early termination of the transcode because it required the new file to be smaller than the old file.