Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
===========================================
+ Coverage 59.06% 74.10% +15.03%
===========================================
Files 129 146 +17
Lines 6738 6291 -447
===========================================
+ Hits 3980 4662 +682
+ Misses 2758 1629 -1129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ta.cquest.org is down
… avoid circular imports
c2b6cba to
5abdcca
Compare
…ration so that travel costs recompute when a new GTFS feed is added + add a GTFS builder class + integration test for time varying GTFS parameter
… GTFS when testing for GTFS changes during a simulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
This PR adds support for iteration-based time-varying parameter values.
See #281.
Changes
mobility.runtime.parameter_profiles:ParameterProfileas the shared base classScalarParameterProfilefor scalar parameters withsteporlinearevolutionListParameterProfilefor step-wise list-valued parametersSimulationStepto identify the current iterationmobility.runtime.validation_types.value_of_time,value_of_time_stay_home, andradiation_lambdato accept either constant scalar values orScalarParameterProfilevalues.Activity.get_parameters_at_step(step)and a shared per-iteration activity-parameter resolution path so activity parameters are resolved once per iteration and then reused downstream.GroupDayTripsto use step-specific activity parameters when computing:PublicTransportRoutingParameters.additional_gtfs_filesto accept either a constantlist[str]or aListParameterProfile.GroupDayTripsrun boundary through an iteration-scoped resolved transport-cost aggregator.mobility.transport.modes.public_transport.gtfs_builderto generate synthetic GTFS feeds from simplified declarative inputs.Motive/MotiveParametersreferences introduced by the older implementation path and align the feature with the currentActivity/GroupDayTripsarchitecture from the refactor branch.Examples
The API to make the value of time for the work activity change from 4 €/h to 8 €/h at iteration 3 is:
It is also possible to get a gradual change with linear interpolation. Here the value of time will be 4, 6, and 8 at iterations 1, 2, and 3:
The existing API still works for constant parameters:
Step-wise list-valued parameters are currently supported for
PublicTransportRoutingParameters.additional_gtfs_files. For example, to switch the additional GTFS files used by public transport routing at iteration 2: