Swapped npm to bun for faster installation#15
Conversation
|
Hi mate, Thanks for the contribution! I appreciate that you made a PR into the dev branch, and all the changes looks good to me, i really like more the bun/uv/poetry combo, and i would have made the same at some point, so again thanks. There's only 2 point i would like to highlight and that i would like to resolve before merge: 1 - while the switch to poetry is cool, there's a deps "esbuild 0.25.1" which contains a couple of CVE, they may not be dangerous in the context we use it, i'm not sure tbh, so i prefer not to have it. 2- i saw you left a couple of data.db files into the backend folder, if you could please remove them that would be great. once this 2 point are ok i can merge. PS: i saw the other work you're doing, and that's some QOL for sure, so if you want to integrate that too with another PR or adding them to this with the aforementioned issue, do as you wish. PPS: i may be away for a while during holidays, but if you find the time to fix the PR i will find the time to merge it :) |
…tignore excludes backend data, uploads, and cache folders. General project hygiene and QOL improvements
|
I think I've made the suggested changes. Hope this helps. Merry Christmas and Happy New Year! 🎅🎆 |
Hi man, That's some great improvements, thank you! you almost did everything correct ahahah you now pushed an .stl file and some .pyc files, but that's nothing and the rest seems perfectly fine. I'll clean up this tomorrow morning and merge everything for a new release! Wish you some good holidays, have a good Christmas and happy new year! 😁 |
|
Thanks for the improvements! Have nice holidays! |
|
hi @beecho01 , have a good new year eve mate. cheers. |
|
Hi mate, Hope you had a good holidays. The bun image comes in multiple os options. I chose the alpine option due to the size. After a quick Google search, the AI mode suggests that its a cpu architecture issue. Trying another os base might work better. Here are the others if you'd like me to attempt to replicate or chose another option: https://share.google/1FkDRO3QyV2siSf4k Thanks |
|
Hi man!
I had fortunately, hope the same for you!
By the way i got an error related to docker, I don't remember exactly, i
would definitely like to switch to it, but i had some previous problems
with the hardware on my old homelab.
And i found an issue related to my problem that was somewhat complicated to
fix so i did not investigate further cuz i wanted to push the changes you
made 😅
I'll try to test some other images and check better the problem in the
coming days if i can.
Thank for the contribution and the help 💪
Cheers,
Samuel
…On Tue, Jan 6, 2026, 21:49 James Beeching ***@***.***> wrote:
*beecho01* left a comment (moddroid94/STLVault#15)
<#15 (comment)>
Hi mate,
Hope you had a good holidays.
What sort of issue are you getting. The bun image comes in multiple os
options. I chose the alpine option due to the size.
Here are the others if you'd like me to attempt to replicate or chose
another option: https://share.google/1FkDRO3QyV2siSf4k
Thanks
James
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5Z37UHCQASMX66J3HCMNL4FQNVDAVCNFSM6AAAAACPV7RIXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJWGI4DOOJZGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Hey Man, I've rediscovered why it won't work, unfortunately my homelab is old af, the CPU does not have SSE4.2, which is a baseline dependency for Bun, that's why it won't work on my setup. I was thinking about a script to detect if the cpu supports the instruction and then choose which package manager to choose, but it may not be that good of a solution. |
|
Its not a bad idea, let me have a play, see what I can come up with. |
|
What about something like this? Haven't tested it but can if you want me to. |
|
@beecho01 Yeah, exactly something like that ahahaha thanks mate! building bun on the node:alpine image isn't a problem? cheers :) |
|
I thought about it a bit more and did a little research and I realised I did make one little mistake by not closing with a CMD and missing a pre-requisite for Bun. Also, it seems you cannot use grep to switch base images dynamically within a single Dockerfile, so my initial thinking to install bun alongside node within the node-alpine image should allow for either to run based on the CPU architecture, which should hopefully provide best of both worlds. I'm just pulling the latest prod image, and I will edit the frontend/Dockerfile before running, see what happens and report back! |
|
It appears to work for me, see the logs below: |
|
Hi man, i think this is somewhat close to what we need, i still got the error as the installation of bun fails on my system, so the whole image won't build. the multi stage is fun and cool, but is more complex to make, the entrypoint is the simplest but requires to have 2 different docker files, one for CPU set basically from the docker-compose in the root we set the frontend dockerfile based on an ENV, given a sensible default, that way we even allow to choose manually for testing. |
Various edits to help with installation speed and changes for mobile device screens:
Swapped npm to bun for faster installation
Moved from h-screen to h-dvh to remove overflow issues on mobile devices
Added x-axis padding consistency to sidebar elements
Migrated backend to use uv rather than pip for faster setup speed
Added pycache to gitignore
Made changes to make sure that file.filename is a string before passing it to os.path.splitext