fix: fix URL import extension and STEP thumbnail#23
Merged
Merged
Conversation
…o file on save fixes #22 formatting fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the preview for the STEP file is generated when the model is imported from URL
WARNING: All the model imported via URL could suffer a problem where the extension is missing from the filename, it is not corrupted or anything, and you wont notice from the UI, but when downloaded the file is without extension, you can just add the dot between the name and the extension and the file will open.
This PR fixes this problem, but will NOT retroactively fix the previously imported models, so it is advised to re-import them, i'm sorry for the error, but this is still somewhat a beta.
fix #22