variants: simplify dispatch and session by reducing method boilerplate#8
Open
StevenRChen wants to merge 3 commits intomainfrom
Open
variants: simplify dispatch and session by reducing method boilerplate#8StevenRChen wants to merge 3 commits intomainfrom
StevenRChen wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify variant dispatch and session by replacing per-method boilerplate with generic handlers backed by reflect.
Motivation and Context
The dispatcher and backend session had separate handler functions for every MCP method (ListTools, ListResources, CallTool, Subscribe, etc.), each following an identical pattern: extract params, inject metadata, call inner handler, cast result. This meant ~250 lines of near-identical code across dispatch.go and session.go, and every new MCP method required adding another copy.
How Has This Been Tested?
All existing unit and integration tests pass (go test -v ./...)
Breaking Changes
None. All changes are internal to the variants package. Public API is unchanged.
Types of changes
Refactor (non-breaking change which fixes an issue)