client:build.base: env.CLIENT__BASE_HREF #992
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Changes Made
Added a client build configuration input via environment variable: CLIENT__BASE_HREF
This enables deploying the Inspector client application under different base routes
Default behavior remains intact when the variable is not set
Testing
Testing
build and run | localhost APACHE
Test Results and/or Instructions
npm run build > without using CLIENT__BASE_HREF | to check the non-breaking ness of the change
SET CLIENT__BASE_HREF=/check && npm run build
Checklist
no code changes
only client build configuration extended
Breaking Changes
None
Additional Context
This change makes it easier to deploy the Inspector client behind reverse proxies or under sub-paths without additional build-time customization.