fix(oauth): preserve existing refresh_token when server omits it#2272
Closed
Jah-yee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix(oauth): preserve existing refresh_token when server omits it#2272Jah-yee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Jah-yee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Per RFC 6749 Section 6, the authorization server MAY issue a new refresh token in the refresh response. If the server does not issue a new refresh token, the client must preserve the existing one. This fix preserves the existing refresh_token when the OAuth server's refresh response omits it, which is common for providers like Google, Auth0, and Okta. Fixes modelcontextprotocol#2270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 6749 Section 6, the authorization server MAY issue a new refresh token. This fix preserves the existing refresh_token when the response omits it.