update base ruby logic and settings for supporting ruby 2.6#238
Open
shutkovMaksim wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
update base ruby logic and settings for supporting ruby 2.6#238shutkovMaksim wants to merge 2 commits intomodelcontextprotocol:mainfrom
shutkovMaksim wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Member
|
Why is this support needed? |
koic
reviewed
Feb 24, 2026
| spec.require_paths = ["lib"] | ||
|
|
||
| spec.add_dependency("json-schema", ">= 4.1") | ||
| spec.add_dependency("json-schema", ">= 4.1", "< 6.0") |
Member
There was a problem hiding this comment.
This would create an undesirable restriction for users on newer Ruby versions, preventing them from using bugfix releases and other updates. Instead of restricting the version, please consider proposing changes to support it on the dependent gem side. voxpupuli/json-schema#561 may be helpful as a reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update code to support ruby 2.6