Use accessor method in server_context_with_meta instead of ivar#273
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Mar 27, 2026
Merged
Conversation
## Motivation and Context `server_context_with_meta` reads `@server_context` (the instance variable) directly instead of calling the `server_context` accessor method. This prevents subclasses from overriding `server_context`. Ffor example, to provide thread-local context in multi-threaded servers like Puma. Fixes modelcontextprotocol#271. ## How Has This Been Tested? Added a regression test and passed. ## Breaking Changes None. This restores the expected behavior of `attr_accessor :server_context`.
atesgoral
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
server_context_with_metareads@server_context(the instance variable) directly instead of calling theserver_contextaccessor method. This prevents subclasses from overridingserver_context. Ffor example, to provide thread-local context in multi-threaded servers like Puma.Fixes #271.
How Has This Been Tested?
Added a regression test and passed.
Breaking Changes
None. This restores the expected behavior of
attr_accessor :server_context.Types of changes
Checklist