Update URL pattern to use uri-template format#13
Open
Fannon wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Update URL pattern to use uri-template format#13Fannon wants to merge 1 commit intomodelcontextprotocol:mainfrom
Fannon wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
In the description it already mentions that this is an URL Template. The regexp is more restrictive than this. Our actual problem is: MCP Servers might not know their full absolute URL, this is often defined later, e.g. by the Gateway. So for some MCP servers, they can only provide a relative URL or a templated URI. Is this correct or are there reasons why the current regexp insists on an absolute URL? I understand we want absolute URLs at the very end (in the registry), but when you self-describe yourself you might not yet have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the description it already mentions that this is an URL Template. The regexp is more restrictive than this.
Our actual problem is: MCP Servers might not know their full absolute URL, this is often defined later, e.g. by the Gateway. So for some MCP servers, they can only provide a relative URL or a templated URI.
Is this correct or are there reasons why the current regexp insists on an absolute URL? I understand we want absolute URLs at the very end (in the registry), but when you self-describe yourself you might not yet have it.