Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-tasks-share.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@modelcontextprotocol/server': patch
---

fix(server): pass task context as the second argument for no-schema task handlers
19 changes: 13 additions & 6 deletions packages/server/src/experimental/tasks/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,24 @@ import type { BaseToolCallback } from '../../server/mcp.js';
export type CreateTaskRequestHandler<
SendResultT extends Result,
Args extends StandardSchemaWithJSON | undefined = undefined
> = BaseToolCallback<SendResultT, CreateTaskServerContext, Args>;
> = Args extends StandardSchemaWithJSON
? BaseToolCallback<SendResultT, CreateTaskServerContext, Args>
:
| ((ctx: CreateTaskServerContext) => SendResultT | Promise<SendResultT>)
| ((_args: undefined, ctx: CreateTaskServerContext) => SendResultT | Promise<SendResultT>);

/**
* Handler for task operations (`get`, `getResult`).
* @experimental
*/
export type TaskRequestHandler<SendResultT extends Result, Args extends StandardSchemaWithJSON | undefined = undefined> = BaseToolCallback<
SendResultT,
TaskServerContext,
Args
>;
export type TaskRequestHandler<
SendResultT extends Result,
Args extends StandardSchemaWithJSON | undefined = undefined
> = Args extends StandardSchemaWithJSON
? BaseToolCallback<SendResultT, TaskServerContext, Args>
:
| ((ctx: TaskServerContext) => SendResultT | Promise<SendResultT>)
| ((_args: undefined, ctx: TaskServerContext) => SendResultT | Promise<SendResultT>);

/**
* Interface for task-based tool handlers.
Expand Down
7 changes: 6 additions & 1 deletion packages/server/src/server/mcp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1206,7 +1206,12 @@ function createToolExecutor(
if (inputSchema) {
return taskHandler.createTask(args, taskCtx);
}
// When no inputSchema, call with just ctx (the handler expects (ctx) signature)

if (taskHandler.createTask.length >= 2) {
return taskHandler.createTask(undefined, taskCtx);
}

// When no inputSchema, preserve the existing context-only handler signature.
return (taskHandler.createTask as (ctx: CreateTaskServerContext) => CreateTaskResult | Promise<CreateTaskResult>)(taskCtx);
};
}
Expand Down
88 changes: 88 additions & 0 deletions packages/server/test/server/mcp.tasks.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
import type { CreateTaskServerContext, JSONRPCMessage, TaskServerContext } from '@modelcontextprotocol/core';
import { InMemoryTaskStore, InMemoryTransport, LATEST_PROTOCOL_VERSION } from '@modelcontextprotocol/core';
import { describe, expect, it, vi } from 'vitest';
import { McpServer } from '../../src/index.js';
import type { ToolTaskHandler } from '../../src/index.js';

describe('registerToolTask', () => {
it('passes task context as the second argument for no-schema task handlers', async () => {
const server = new McpServer(
{ name: 'task-test', version: '1.0.0' },
{
capabilities: {
tasks: {
requests: { tools: { call: {} } },
taskStore: new InMemoryTaskStore()
}
}
}
);

let receivedArgs: unknown = 'not-called';
let receivedCtx: CreateTaskServerContext | undefined;

const handler = {
createTask: async (_args: undefined, ctx: CreateTaskServerContext) => {
receivedArgs = _args;
receivedCtx = ctx;
const task = await ctx.task.store.createTask({ ttl: ctx.task.requestedTtl });
return { task };
},
getTask: async (_args: undefined, ctx: TaskServerContext) => ({
taskId: ctx.task.id ?? 'unused',
status: 'working' as const,
ttl: null,
createdAt: new Date(0).toISOString(),
lastUpdatedAt: new Date(0).toISOString()
}),
getTaskResult: async () => ({
content: [{ type: 'text' as const, text: 'done' }]
})
} satisfies ToolTaskHandler<undefined>;

server.experimental.tasks.registerToolTask('no-schema-task', { description: 'Create a task without input arguments' }, handler);

const [clientTransport, serverTransport] = InMemoryTransport.createLinkedPair();
await server.connect(serverTransport);
await clientTransport.start();

const responses: JSONRPCMessage[] = [];
clientTransport.onmessage = message => responses.push(message);

await clientTransport.send({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: LATEST_PROTOCOL_VERSION,
capabilities: {},
clientInfo: { name: 'task-client', version: '1.0.0' }
}
} as JSONRPCMessage);
await clientTransport.send({ jsonrpc: '2.0', method: 'notifications/initialized' } as JSONRPCMessage);
await clientTransport.send({
jsonrpc: '2.0',
id: 2,
method: 'tools/call',
params: {
name: 'no-schema-task',
task: { ttl: 600 }
}
} as JSONRPCMessage);

await vi.waitFor(() => expect(responses.some(response => 'id' in response && response.id === 2)).toBe(true));

expect(receivedArgs).toBeUndefined();
expect(receivedCtx?.task.store).toBeDefined();
expect(receivedCtx?.task.requestedTtl).toBe(600);

const response = responses.find(message => 'id' in message && message.id === 2) as {
error?: unknown;
result?: { task: { ttl?: number | null } };
};
expect(response.error).toBeUndefined();
expect(response.result?.task.ttl).toBe(600);

await server.close();
});
});
Loading