Skip to content

Feature/moose 351/border settings#326

Open
Vinsanity wants to merge 4 commits intomainfrom
feature/MOOSE-351/border-settings
Open

Feature/moose 351/border settings#326
Vinsanity wants to merge 4 commits intomainfrom
feature/MOOSE-351/border-settings

Conversation

@Vinsanity
Copy link
Copy Markdown
Contributor

What does this do/fix?

This pull request adds and configures border support for several core blocks in the theme, and introduces a JavaScript filter to relabel the "Shadow" option in the editor UI for improved clarity. The changes also include a workaround for a known Gutenberg label bug.

The most important changes are:

Editor UI Improvements:

  • Added a new filters module (editor/filters/index.js) that registers an i18n filter to relabel the "Shadow" label to "Border & Shadow" in the block editor, addressing a Gutenberg label bug. This filter is initialized as part of the editor setup. [1] [2] [3]

Theme Block Support Enhancements:

  • Enabled border support (color, radius, style, width) for core/columns, core/cover, and core/group blocks in theme.json. [1] [2]
  • Enabled shadow support for the core/group block in theme.json.

Global Theme Settings:

  • Added global border settings to theme.json, explicitly disabling border color, radius, style, and width by default to ensure block-level control.

QA

Links to relevant issues

Screenshots/video:

Pull request checklist

  • I've added a changelog entry for these changes.
  • I've linked to a relevant Jira issue.
  • I've captured a screenshot or screencast of the changes and linked it above.

…er and shadow options; implement MutationObserver for dynamic updates.
Copy link
Copy Markdown
Collaborator

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants