[MOOSE-354] FE: Group block left/right padding in editor#329
[MOOSE-354] FE: Group block left/right padding in editor#329GeoffDusome wants to merge 2 commits intomainfrom
Conversation
|
@dpellenwood @Vinsanity Do either of you know if, because this was an issue on learn.tri.be if I have to also make this update there, or do we port stuff back there? |
spadilha
left a comment
There was a problem hiding this comment.
🍏 Just double check if the changes in package-lock.json was intentional.
Every time I run |
ac061c8 to
ee44924
Compare
dpellenwood
left a comment
There was a problem hiding this comment.
@Vinsanity & @LayaTaal , Is this related to the discussion we had yesterday about padding on group blocks? If so, can we loop Geoff and Marina in on this convo before this gets merged?
This is related @dpellenwood. I think we should go over this all once more with design to align on a permanent solution that works for them. |
What does this do/fix?
Ports the group block padding fix from nexcess PR #25 back to Moose. This resolves two bugs:
Approach: Instead of setting padding in each variation's JSON file, padding is now applied via CSS (in
style.pcssand a neweditor.pcss). This allowshas-transparent-backgroundto override it cleanly without needing!importantescalation.Changes:
spacing.paddingfrom all group variation JSON files (10-white,20-light,30-dark,40-brand)style.pcssto apply themed padding via:is(:--light-themes, :--dark-themes)selector and addpadding: 0 !importantto transparent background caseeditor.pcssto mirror the frontend padding behavior in the block editoreditor.jsto import the neweditor.pcssQA
Links to relevant issues
Screenshots/video:
Pull request checklist