[fix] modm::Saturated

[TomSaw]

To PR the generic colors nextly from #665 , i would like to PR this fixed modm::Saturated first.

TODO

• Add missing operator+= / -=
• Extend tests to more types and more cases

[salkinium]

Nice!

[TomSaw]

Done! Please review @salkinium

[salkinium]

Lovely!

[TomSaw]

Could be merged @salkinium 😋

[TomSaw]

... still in exams phase?

[salkinium]

... still in exams phase?

Way worse: master thesis phase for the next ~6 months.

[salkinium]

Could be merged @salkinium 😋

Rebase and squash?

[TomSaw]

Way worse: master thesis phase for the next ~6 months.

So i stay in @-poke-mode for ~6 months @salkinium 😬 !? Hope you find a breath in between.

[salkinium]

So i stay in @-poke-mode for ~6 months @salkinium 😬 !?

You should probably always stay in poke mode, since you push so many commits that I don't really know when do reviews or merges 😜 So it's best if you just tell me, that helps me and you.

[TomSaw]

Thanks for the feedback, i thought like pushing commits that hard isn't normal. I rely to much on githubs CI and it always surprises me - repeating - what else got broken with my changes.

I can run anything within '/test' but there is more! Running githubs complete CI locally would save a ton of nerves and CO2. Is there some 'best practice' to read? @salkinium

[salkinium]

See this Readme here: https://github.com/modm-io/modm/tree/develop/test#unit-tests

[salkinium]

There are also a bunch of scripts in tools/scripts, for the usage consult the GitHub CI runner: https://github.com/modm-io/modm/blob/develop/.github/workflows/linux.yml#L32-L62

[salkinium]

The compile-all tests take a very long time locally, I suggest only running them only locally for a subset of devices if the ci:hal label has failed.
By calling it manually you can filter the failing devices by their prefix python3 run_all.py $PREFIX which reduced the scope significantly.
There are also ignored devices, but they are centrally handled by repo.lb: https://github.com/modm-io/modm/blob/develop/test/all/ignored.txt

[TomSaw]

Perfect. Thank you!