[architecture] Require setting SPI config in SpiDevice based drivers#820
Draft
chris-durand wants to merge 4 commits intomodm-io:developfrom
Draft
[architecture] Require setting SPI config in SpiDevice based drivers#820chris-durand wants to merge 4 commits intomodm-io:developfrom
SpiDevice based drivers#820chris-durand wants to merge 4 commits intomodm-io:developfrom
Conversation
The SPI configuration is specified as a non-type template parameter to `modm::SpiDevice`. `SpiDevice` will provide a `configureBus()` function to apply the required mode settings for the device.
Member
Author
|
The 😆 |
Member
Author
|
I found the mistake, now without segfault. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to move the discussion about a new API for setting the SPI configuration in
SpiDevicebased device drivers to a different place.As a first step a new
SpiConfigurationstruct is added underarchitecture. Furthermore,modm::SpiDevicewill take that config struct as a non-type template parameter and provides a defaultconfigureBus()function that applies the settings to the SPI master.EDIT: this does not work as expected, the platform-specific
SpiMasterdriver won't acceptmodm::Spi::DataModeas an argument toSpiMaster::setDataMode().modm::platform::SpiMaster::DataModehas to be used.