Merged
Conversation
…ort moving objects
- Move the MoveCopyFlag class to a separate file to import in different test files (DRY) - Create tests for moving objects in push_front - Overload push_front to support moving
- Constructor with initalizer list - Constructor with begin and end iterators
- Create helper function extract_node_and_link_prev_with_next to extract node without affecting value or iterator - Create helper function emplace_node_before to insert node at any desired position without affecting value or iterator - Modify pop_back(), pop_front() and erase_middle_node() to move the values insead of copying them
… in link_new_back_node function
- Define (=) operator for the MoveCopyFlag to fix the deleted operator error - Overload insert to support moving without copying - Use emplace_back instead of push_back to avoid unnecessary moves or copies - Use move_to_begin list function instead of push_front with erase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release the move_to_front feature
move_to_frontwhich allows for reorderingOrderedMapentries in constant timeO(1).DoublyLinkedListandOrderedMapinternals to adhere to move and copy semantics and avoid unnecessary or unexpected moving / copying of objects.DoublyLinkedListandOrderedMap.