include CJS build output in mcp-adapter publish#66
Merged
encodedz merged 1 commit intomondaycom:masterfrom Mar 9, 2026
Merged
Conversation
maslo55555
approved these changes
Mar 8, 2026
encodedz
reviewed
Mar 8, 2026
Collaborator
encodedz
left a comment
encodedz
left a comment
There was a problem hiding this comment.
dont forget to commit a conventional commit styled one so u get auto-release
| "outputs": ["{projectRoot}/dist"], | ||
| "options": { | ||
| "command": "tsc --build packages/mcp-adapter/tsconfig.json" | ||
| "command": "cd packages/mcp-adapter && npm run build" |
Collaborator
There was a problem hiding this comment.
Why the CD ? shouldn't need to
Contributor
Author
There was a problem hiding this comment.
we use nx:run-commands from the root, so npm run build will execute the root build script. In all other packages this is the same, maybe was missed here
Collaborator
There was a problem hiding this comment.
Yea, It should have a sourceRoot option which should opt-in this behaviour - but if all the wokrspace is using this convention lets proceed.
EranZidkiya
force-pushed
the
fix/eran/cjs-output-mcp-adapter
branch
from
7abaef5 to
fbc90db
Compare
encodedz
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.