Skip to content

fix(get_updates): treat date-only toDate as end of day #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gujiassh wants to merge 1 commit into from
Closed

fix(get_updates): treat date-only toDate as end of day #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...agent-toolkit/src/core/tools/platform-api-tools/get-updates-tool/get-updates-tool.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ describe('Get Updates Tool', () => {
await expect(tool.execute({ itemId: 123, page: 0 } as any)).rejects.toThrow();
});

it('Successfully gets board updates with date range filtering', async () => {
it('Successfully gets board updates with date-only range filtering', async () => {
mocks.setResponse(mockBoardUpdatesResponse);
const tool = new GetUpdatesTool(mocks.mockApiClient);

Expand All @@ -410,7 +410,7 @@ describe('Get Updates Tool', () => {
limit: 25,
page: 1,
fromDate: '2024-01-01T00:00:00Z',
toDate: '2024-01-31T00:00:00Z',
toDate: '2024-01-31T23:59:59Z',
boardUpdatesOnly: true,
}),
);
Expand Down
11 changes: 8 additions & 3 deletions ...ages/agent-toolkit/src/core/tools/platform-api-tools/get-updates-tool/get-updates-tool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export const getUpdatesToolSchema = {
),
};

function normalizeToISO8601DateTime(date: string): string {
function normalizeToISO8601DateTime(date: string, boundary: 'start' | 'end' = 'start'): string {
if (/^\d{4}-\d{2}-\d{2}$/.test(date)) {
return `${date}T00:00:00Z`;
return boundary === 'end' ? `${date}T23:59:59Z` : `${date}T00:00:00Z`;
}
return date;
}
Expand Down Expand Up @@ -110,7 +110,12 @@ export class GetUpdatesTool extends BaseMondayApiTool<typeof getUpdatesToolSchem
...variables,
boardId: input.objectId,
boardUpdatesOnly: !(input.includeItemUpdates ?? false),
...(input.fromDate && input.toDate ? { fromDate: normalizeToISO8601DateTime(input.fromDate), toDate: normalizeToISO8601DateTime(input.toDate) } : {}),
...(input.fromDate && input.toDate
? {
fromDate: normalizeToISO8601DateTime(input.fromDate, 'start'),
toDate: normalizeToISO8601DateTime(input.toDate, 'end'),
}
: {}),
});
}

Expand Down