fix: handle builtin dictionaries as unicode data, not bytes#11
Open
neta79 wants to merge 1 commit intomonkeython:masterfrom
Open
fix: handle builtin dictionaries as unicode data, not bytes#11neta79 wants to merge 1 commit intomonkeython:masterfrom
neta79 wants to merge 1 commit intomonkeython:masterfrom
Conversation
…vents the generator outputting repr() of binary data, resulting in a sequence of b'blahblahs'
|
+1 This is a huge problem in python3. It essentially makes the pip install useless. Only option for me was to clone your library and do exactly what @neta79 is doing here. |
|
+1 Thanks @neta79, I'm cloning directly from your branch. @monkeython, love to see this get merged in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the generator from outputting repr() of binary data, resulting in a sequence of b'blahblahs'.
If you plan to release a v1.0.6 on pypi, please consider merging this. It fixes things for py3.