Promote 20260422#1
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d13b1ae8f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ignore( | ||
| outgoing_stream.blocking_write_and_flush(b"Hello World!".to_fixedarray()), | ||
| ) | ||
| outgoing_stream.drop() | ||
| outgoing_body.finish(None).unwrap_or_error() | ||
| ignore(outgoing_body.finish(None)) |
There was a problem hiding this comment.
Both blocking_write_and_flush and outgoing_body.finish can return errors (for example when the client disconnects or when body finalization fails), but this change discards both results with ignore(...). That turns real response-delivery failures into silent success paths, making truncated/corrupted responses hard to detect and debug in production; previously, failures were surfaced via error handling. Please propagate or at least log these errors instead of ignoring them.
Useful? React with 👍 / 👎.
1 participant
No description provided.