Skip to content

fix(moon): handle projects without tags in Tags view#93

Merged
milesj merged 1 commit intomoonrepo:masterfrom
bigslycat:fix/moon-get-tag-children-fail
Feb 26, 2026
Merged

fix(moon): handle projects without tags in Tags view#93
milesj merged 1 commit intomoonrepo:masterfrom
bigslycat:fix/moon-get-tag-children-fail

Conversation

@bigslycat
Copy link
Copy Markdown
Contributor

Fixes #92.

  • Bump @moonrepo/types to 2.0.1 to match the Moon v2.0.1 toolchain and current config typings.
  • Fix VS Code Tags view refresh by guarding optional project.config.tags (treat missing tags as an empty list), preventing repeated notification spam / tree refresh errors.

Workaround (until the next extension release):

  • ensure every project has at least one tag (non-empty tags array), e.g. tags: ['_workaround'].

@milesj milesj merged commit 15eead3 into moonrepo:master Feb 26, 2026
3 checks passed
@milesj
Copy link
Copy Markdown
Contributor

milesj commented Feb 26, 2026

Thanks!

@github-actions
Copy link
Copy Markdown

Run report for 15eead33 (22)

Total time: 5.4s | Comparison time: 8.7s | Estimated savings: 3.4s (38.6% faster)

Action Time Status Info
🟩 SyncWorkspace 15.2ms Passed
🟩 SyncProject(vscode-extension) 1.2ms Passed
🟩 SetupProto(0.54.1) 1.7s Passed
⬛️ SetupToolchain(node:22.17.0) 112.4ms Skipped
⬛️ SetupToolchain(yarn:4.9.2) 99.5ms Skipped
⬛️ SetupToolchain(javascript) 0.1ms Skipped
🟩 SetupEnvironment(javascript) 0.9ms Passed
⬛️ InstallDependencies(javascript) 0.6ms Skipped
🟩 RunTask(vscode-extension:test) 934.3ms Passed
🟩 RunTask(vscode-extension:format) 1.8s Passed
🟩 RunTask(vscode-extension:build) 1.9s Passed
🟩 RunTask(vscode-extension:lint) 3s Passed
🟩 RunTask(vscode-extension:typecheck) 2.5s Passed
Environment

OS: Linux
Matrix:

node-version = 22
Changed files
packages/vscode-extension/package.json
packages/vscode-extension/src/projectsView.ts
yarn.lock

@github-actions
Copy link
Copy Markdown

Run report for 15eead33 (20)

Total time: 5s | Comparison time: 7.1s | Estimated savings: 2.1s (29.8% faster)

Action Time Status Info
🟩 SyncWorkspace 10.7ms Passed
🟩 SyncProject(vscode-extension) 1.3ms Passed
🟩 SetupProto(0.54.1) 1.9s Passed
⬛️ SetupToolchain(node:22.17.0) 128.7ms Skipped
⬛️ SetupToolchain(yarn:4.9.2) 91.4ms Skipped
⬛️ SetupToolchain(javascript) 0ms Skipped
🟩 SetupEnvironment(javascript) 0.8ms Passed
⬛️ InstallDependencies(javascript) 0.3ms Skipped
🟩 RunTask(vscode-extension:test) 775.2ms Passed
🟩 RunTask(vscode-extension:format) 1.4s Passed
🟩 RunTask(vscode-extension:build) 1.5s Passed
🟩 RunTask(vscode-extension:typecheck) 2.4s Passed
🟩 RunTask(vscode-extension:lint) 2.1s Passed
Environment

OS: Linux
Matrix:

node-version = 20
Changed files
packages/vscode-extension/package.json
packages/vscode-extension/src/projectsView.ts
yarn.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[VS Code] Notification spam: Cannot read properties of undefined (reading 'length') during projects tree refresh

2 participants