fix: Refactor moon installation detection logic#95
Merged
milesj merged 1 commit intomoonrepo:masterfrom Mar 26, 2026
Merged
Conversation
Moon 2 supports the moon folder under .config workspace folder. But this was causing the extension to fail with the info that is not finding the moon binary. This was because it could not recognize the workspace. This fixes this behavior.
Contributor
|
Thanks! |
Run report for f7d0178f
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
12.1ms | Passed | |
| 🟩 | SyncProject(vscode-extension) |
1.4ms | Passed | |
| 🟩 | SetupProto(0.54.1) |
1.8s | Passed | |
| ⬛️ | SetupToolchain(node:22.17.0) |
230.6ms | Skipped | |
| ⬛️ | SetupToolchain(yarn:4.9.2) |
50.5ms | Skipped | |
| ⬛️ | SetupToolchain(javascript) |
0ms | Skipped | |
| 🟩 | SetupEnvironment(javascript) |
0.9ms | Passed | |
| ⬛️ | InstallDependencies(javascript) |
0.5ms | Skipped | |
| 🟩 | RunTask(vscode-extension:test) |
808.3ms | Passed | |
| 🟩 | RunTask(vscode-extension:format) |
1.4s | Passed | |
| 🟩 | RunTask(vscode-extension:build) |
1.5s | Passed | |
| 🟩 | RunTask(vscode-extension:typecheck) |
2.5s | Passed | |
| 🟩 | RunTask(vscode-extension:lint) |
2.4s | Passed |
Environment
OS: Linux
Matrix:
node-version = 20
Changed files
packages/vscode-extension/src/workspace.ts
Run report for f7d0178f
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
12.2ms | Passed | |
| 🟩 | SyncProject(vscode-extension) |
1.2ms | Passed | |
| 🟩 | SetupProto(0.54.1) |
2.2s | Passed | |
| ⬛️ | SetupToolchain(node:22.17.0) |
159.9ms | Skipped | |
| ⬛️ | SetupToolchain(yarn:4.9.2) |
91.9ms | Skipped | |
| ⬛️ | SetupToolchain(javascript) |
0.1ms | Skipped | |
| 🟩 | SetupEnvironment(javascript) |
0.8ms | Passed | |
| ⬛️ | InstallDependencies(javascript) |
0.6ms | Skipped | |
| 🟩 | RunTask(vscode-extension:test) |
830.6ms | Passed | |
| 🟩 | RunTask(vscode-extension:build) |
1.4s | Passed | |
| 🟩 | RunTask(vscode-extension:format) |
1.6s | Passed | |
| 🟩 | RunTask(vscode-extension:typecheck) |
2.6s | Passed | |
| 🟩 | RunTask(vscode-extension:lint) |
2.4s | Passed |
Environment
OS: Linux
Matrix:
node-version = 22
Changed files
packages/vscode-extension/src/workspace.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moon 2 supports the moon folder under .config workspace folder. But this was causing the extension to fail with the info that is not finding the moon binary. This was because it could not recognize the workspace. This fixes this behavior.