Open
Conversation
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Contributor
|
What use case is this solving exactly? |
Contributor
Author
|
To be honest, I got an error in a fresh new crate that used the schematic example from the README but didn't include serde as a dependency. I guess/suspect as the crate grows that dependency might get pulled in, but since the example in the README did not work out of the box I figured I could either make it work without the need to pull in serde manually, or update the example in the README. I did the former. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the user doesn't need
serdein their list of dependencies. This solution breaks if someone renames theschematicpackage to something else, but AFAIK there is no good solution to this?