Skip to content

Conversation

@mcintyrehh
Copy link

This PR adds Opus to the supported audio codecs for the MoQ service.

Testable with: moq-dev/moq#811

image image

@mcintyrehh mcintyrehh force-pushed the feat/add-opus-encoder branch from c896a1b to e07e436 Compare January 2, 2026 00:21
@mcintyrehh mcintyrehh changed the title Add Opus audio decoder as an option Add Opus audio encoder as an option Jan 2, 2026
@mcintyrehh mcintyrehh changed the title Add Opus audio encoder as an option Add Opus audio encoder Jan 2, 2026
@mcintyrehh mcintyrehh mentioned this pull request Jan 2, 2026
3 tasks
@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Walkthrough

This pull request adds Opus to the set of supported audio codecs in the MoQ (Media over QUIC) implementation. src/moq-output.cpp registers "aac;opus" for output, and src/moq-service.cpp updates the global audio codecs array to include "opus" alongside "aac". No control flow, function logic, or exported/public signatures were changed.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Opus audio encoder' directly matches the main changeset: adding Opus codec support to both moq-output.cpp and moq-service.cpp.
Description check ✅ Passed The description clearly states the PR adds Opus to supported audio codecs for the MoQ service, which aligns with the actual changes across both modified files.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c896a1b and e07e436.

📒 Files selected for processing (2)
  • src/moq-output.cpp
  • src/moq-service.cpp
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/moq-service.cpp
  • src/moq-output.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated
Copy link
Collaborator

Let's merge this once we cut/pin a new libmoq version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants