Improve cached startup state and keep directory scans responsive#1
Open
moreaki wants to merge 3 commits intofix/combined-directory-monitoringfrom
Open
Improve cached startup state and keep directory scans responsive#1moreaki wants to merge 3 commits intofix/combined-directory-monitoringfrom
moreaki wants to merge 3 commits intofix/combined-directory-monitoringfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On top of
fix/combined-directory-monitoring, this branch turns the app into a much better "show something immediately, finish work in the background" experience, and adds guardrails for the slow-path cases.The main user-facing changes are:
AppDataStore, instead of starting with an empty main window every time.Update,App, andUpdateButton, but stale cached updates are treated as non-actionable until a fresh check confirms them.UpdateTableViewController,UpdateTableView+Search, andAppListSnapshot, so large refreshes no longer block the UI while snapshots are rebuilt.AppDirectoryCellViewnow uses a shared cached/deduplicated count provider./, the home folder, or a whole volume now triggers a warning inAppLocationViewController, so users are nudged toward choosing a narrower app folder instead of accidentally selecting an entire disk.Under the hood, scan performance and scan behavior were tightened:
BundleCollectornow enumerates candidate.appbundles first and processes them concurrently for larger result sets.BundleCollector,MacAppStoreCheckerOperation,SparkleCheckerOperation, andUpdateCheckCoordinator.AppDirectorynow performs collection work on a utility queue instead of doing that work inline on a generic serial queue with a misleading name.The branch also includes diagnostics and failure UX that fit naturally on top of the combined monitoring base branch:
UpdateCheckCoordinator, so startup failures are not dropped.Observable, disabled by default, so we can later build richer app-aware tracing on top of it.MainWindowController, and the same component is reused from Settings when a location count hits the same failure mode.Localizable.strings.So the PR story is basically:
fix/combined-directory-monitoringfixes correctness: no startup crash, recursive monitoring, visible access-failure handlingVerification
xcodebuild -project Latest.xcodeproj -scheme Latest -configuration Debug CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= buildI did not run the full test suite end-to-end because the existing test-target dependency issue with
CommerceKit/StoreFoundationstill applies.