This repository was archived by the owner on Sep 1, 2023. It is now read-only.
Reserved word fix + Sleep time fix#13
Open
LuisFernandob wants to merge 4 commits intomoriakaice:masterfrom
Open
Reserved word fix + Sleep time fix#13LuisFernandob wants to merge 4 commits intomoriakaice:masterfrom
LuisFernandob wants to merge 4 commits intomoriakaice:masterfrom
Conversation
Removed the 1000 multiplier from the constants hack, grow and weaken times since functions ns.getGrowTime() and similar already return the result in miliseconds.
Altered repo address to redirect for my fork
It was getting error due to reserved word.
Undo the repo address alteration for my fork.
|
Thanks, Luis. Definitely needed or the code takes 1000x times as long. |
|
Great fix, confirmed that this works for me on the latest steam version (1.3.0) along with the web version (1.2.0). |
Kingju777
added a commit
to Kingju777/bitburner
that referenced
this pull request
Jan 13, 2022
Kingju777
added a commit
to Kingju777/bitburner
that referenced
this pull request
Jan 13, 2022
|
Glad I saw this, I was about to deep dive the scripts to figure out why they weren't working. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the 1000 multiplier from getxTime() functions since they return the result in miliseconds already.
altered "hackableServers" var name to "vulnerableServers" due to reserved word bug in some ocasions.