Skip to content

dev: deduping of simple shared code#15

Merged
mosteo merged 1 commit into
mainfrom
dev/dedupe
Jun 1, 2026
Merged

dev: deduping of simple shared code#15
mosteo merged 1 commit into
mainfrom
dev/dedupe

Conversation

@mosteo

@mosteo mosteo commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Deduping of the Any_Impl remains daunting

Deduping of the Any_Impl remains daunting
@mosteo mosteo marked this pull request as ready for review June 1, 2026 07:11
Copilot AI review requested due to automatic review settings June 1, 2026 07:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deduplicates small shared utilities between the Ada 2012 (yeison_12) and Ada 2022 (yeison_22) crates by moving common real-handling and JSON string quoting helpers into Yeison_Utils, and then reusing them from both crates.

Changes:

  • Replaced per-crate Reals generic instantiations with a shared Yeison_Utils.Big_Reals instance (and reused Reals.Negate from that shared instance).
  • Centralized JSON string quoting into Yeison_Utils.JSON_Quote and updated callers to use it.
  • Removed per-crate Nicer_Image functions (now provided from Yeison_Utils via Yeison_Utils.Nicer_Image).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yeison_22/src/yeison.ads Switches Reals to a shared instance; removes local Nicer_Image.
yeison_22/src/yeison.adb Uses shared Reals.Negate and Yeison_Utils.JSON_Quote instead of local helpers.
yeison_12/src/yeison_utils.ads Adds shared JSON_Quote, adds General_Reals.Negate, and introduces shared Big_Reals instance.
yeison_12/src/yeison_12.ads Switches Reals to a shared instance; removes local Nicer_Image.
yeison_12/src/yeison_12.adb Uses shared Reals.Negate and Yeison_Utils.JSON_Quote instead of local helpers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread yeison_22/src/yeison.ads
Comment thread yeison_12/src/yeison_12.ads
@mosteo mosteo merged commit de8347f into main Jun 1, 2026
19 checks passed
@mosteo mosteo deleted the dev/dedupe branch June 1, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants