Skip to content

fix: add colspan and rowspan support#79

Open
ZehranurC wants to merge 15 commits into
mainfrom
feature/table-colspan-rowspan-implementation
Open

fix: add colspan and rowspan support#79
ZehranurC wants to merge 15 commits into
mainfrom
feature/table-colspan-rowspan-implementation

Conversation

@ZehranurC

@ZehranurC ZehranurC commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Add colspan and rowspan configuration to table columns with proper cell rendering and pagination safety.

Type of Change

  • 🆕 New Component
  • ✨ Feature / Enhancement
  • 🐛 Bug Fix
  • 💥 Breaking Change
  • 📦 Build / Dependency / Docs Update
  • 🧹 Code Refactoring

Screenshots / Preview

image image

Checklist

  • Self-reviewed, no leftover logs or debug code
  • Uses design tokens — no hardcoded style values
  • Accessible (keyboard nav, ARIA, contrast)
  • Tests added/updated and passing
  • Storybook story added/updated

How to Test

[#EDKUI-1410]

Comment thread src/lib/components/Table/components/Body/TableBody.tsx Outdated
@ZehranurC ZehranurC changed the title feat(Table): add colspan and rowspan support fix: add colspan and rowspan support Jun 5, 2026

@aktasmehmet aktasmehmet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my review v1 :) There are some issues to fix. Then I'll check later.

This PR is so so so important because it directly manipulates the performance related codes of the component. We'll probably need more reviewers here.

Comment thread src/lib/components/Table/components/Body/TableBody.tsx Outdated
Comment thread src/lib/components/Table/types.ts
Comment thread src/lib/components/Table/types.ts
Comment thread src/lib/components/Table/components/Head/FilterColumnsRow.tsx Outdated
Comment thread src/lib/components/Table/helper.ts Outdated
Comment thread src/lib/components/Table/cellSpan.ts Outdated
Comment thread src/lib/components/Table/cellSpan.ts Outdated
Comment thread src/lib/components/Table/components/Foot/ColumnFootArea.tsx Outdated
Comment thread src/lib/components/Table/cellSpan.ts Outdated
Comment thread src/lib/components/Table/helper.ts Outdated
Comment thread src/lib/components/Table/components/Head/FilterColumnsRow.tsx Outdated
Comment thread src/lib/components/Table/types.ts
Comment thread src/lib/components/Table/types.ts
Comment thread src/lib/components/Table/components/Foot/ColumnFootArea.tsx Outdated
Comment thread src/lib/components/Table/components/Foot/ColumnFootArea.tsx Outdated
Comment thread src/lib/components/Table/components/Foot/ColumnFootArea.tsx Outdated
Comment thread src/lib/components/Table/components/Foot/ColumnFootArea.tsx Outdated
Comment thread src/lib/components/Table/components/Foot/ColumnFootArea.tsx Outdated

@aktasmehmet aktasmehmet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to approve but we've both miss some issues. Please check Chromatic. Here is an example:

Image

@aktasmehmet aktasmehmet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Some resolved but some is still there. It is because of the border-collapse you've put.

PS. For the future, please pay extra attention that the issues are validated before requesting a re-review 🙏

@ZehranurC

ZehranurC commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author
Image Some resolved but some is still there. It is because of the border-collapse you've put.

PS. For the future, please pay extra attention that the issues are validated before requesting a re-review 🙏

Footer title and value were being displayed in the same cell. Fixed by re-introducing
the footer cell separation logic that was previously removed.

@aktasmehmet aktasmehmet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some issues and stated below

Comment thread src/lib/components/Table/components/TableContainer.tsx Outdated
Comment thread src/lib/components/Table/components/Foot/ColumnFootArea.tsx Outdated
@aktasmehmet aktasmehmet requested review from a team and removed request for aktasmehmet June 25, 2026 07:21
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants