Skip to content

fix: logo prop refactor to component based#85

Merged
aktasmehmet merged 10 commits into
mainfrom
feature/navbar_accept_external_component_logo
Jun 24, 2026
Merged

fix: logo prop refactor to component based#85
aktasmehmet merged 10 commits into
mainfrom
feature/navbar_accept_external_component_logo

Conversation

@ZehranurC

@ZehranurC ZehranurC commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

NavBar logo prop refactored to accept React components instead of image paths.

Changes:

  • Removed imgPath: string prop
  • Added image: ReactElement for flexible component rendering
  • Supports <img>, <Image>, <NextImage>, and other custom components

Type of Change

  • 🆕 New Component
  • ✨ Feature / Enhancement
  • 🐛 Bug Fix
  • 💥 Breaking Change
  • 📦 Build / Dependency / Docs Update
  • 🧹 Code Refactoring

Checklist

  • Self-reviewed, no leftover logs or debug code
  • Uses design tokens — no hardcoded style values
  • Accessible (keyboard nav, ARIA, contrast)
  • Tests added/updated and passing
  • Storybook story added/updated

How to Test

<NavBar logo={{ image: <img src="logo.png" alt="Logo" />, href: "/" }} />

Comment thread src/lib/components/NavBar/NavBar.test.tsx Outdated
@aktasmehmet aktasmehmet requested a review from a team June 16, 2026 06:09
Comment thread src/lib/components/NavBar/components/NavBarLogo.tsx
Comment thread src/lib/components/NavBar/NavBar.tsx Outdated
Comment thread src/lib/components/NavBar/components/NavBarLogo.tsx Outdated
Comment thread src/lib/components/NavBar/components/NavBarLogo.tsx Outdated
Comment thread src/lib/components/NavBar/NavBar.module.scss Outdated
Comment thread src/lib/components/NavBar/types.ts Outdated
Comment thread src/lib/components/NavBar/NavBar.test.tsx Outdated
Comment thread src/lib/components/NavBar/NavBar.test.tsx Outdated
Comment thread src/lib/components/NavBar/types.ts
Comment thread src/lib/components/NavBar/NavBar.test.tsx
Comment thread src/lib/components/NavBar/NavBar.test.tsx Outdated
Comment thread src/lib/components/NavBar/components/NavBarLogo.tsx Outdated
Comment thread src/lib/components/NavBar/NavBar.test.tsx Outdated
Comment thread src/lib/components/NavBar/types.ts Outdated
Comment thread src/lib/components/NavBar/NavBar.tsx Outdated
Comment thread src/lib/components/NavBar/components/NavBarLogo.tsx Outdated
Comment thread src/lib/components/NavBar/components/NavBarLogo.tsx Outdated
Comment thread src/lib/components/NavBar/components/NavBarLogo.tsx Outdated
Comment thread src/lib/components/NavBar/NavBar.tsx Outdated
@aktasmehmet aktasmehmet merged commit 2af2dab into main Jun 24, 2026
8 of 9 checks passed
@aktasmehmet aktasmehmet deleted the feature/navbar_accept_external_component_logo branch June 24, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants