React Native 0.73 0.79 0.83 Example Apps [sc-185996]#32
Open
chayelheinsen wants to merge 15 commits intomainfrom
Open
React Native 0.73 0.79 0.83 Example Apps [sc-185996]#32chayelheinsen wants to merge 15 commits intomainfrom
chayelheinsen wants to merge 15 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new React Native 0.79 and 0.83 example apps while relocating the existing example to example-0.73, plus integrates push notification support and updates Android build tooling to support newer SDK/Gradle/Kotlin requirements.
Changes:
- Added push notification wiring (iOS entitlements/AppDelegate and Android Firebase +
react-native-notifications). - Updated Android build configuration (SDK 34 / Java 17 / new lint DSL, snapshots repo, Kotlin metadata flag).
- Adjusted Android package names for the moved
example-0.73app.
Reviewed changes
Copilot reviewed 11 out of 11638 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| example-0.73/ios/MovableInkExample/MovableInkExample.entitlements | Adds APNs entitlement for development builds. |
| example-0.73/ios/MovableInkExample/AppDelegate.mm | Adds RNNotifications initialization + APNs delegate forwarding. |
| example-0.73/android/settings.gradle | Adds react-native-notifications included project. |
| example-0.73/android/build.gradle | Adds Android buildscript config and disables tests for react-native-notifications. |
| example-0.73/android/app/src/main/java/com/movableink/app/MainApplication.kt | Updates package + imports notifications package. |
| example-0.73/android/app/src/main/java/com/movableink/app/MainActivity.kt | Updates package to match new namespace. |
| example-0.73/android/app/src/main/AndroidManifest.xml | Points manifest to updated activity/application class names. |
| example-0.73/android/app/build.gradle | Adds Google services plugin + Firebase Messaging deps + Kotlin/packaging tweaks. |
| android/src/main/java/com/rnmovableink/RNMovableInkModule.kt | Adjusts in-app message activity handling, logging, and adds a new (currently empty) RN method. |
| android/gradle.properties | Bumps Kotlin + Android SDK versions for the library build. |
| android/build.gradle | Updates library Gradle config (Java 17, lint DSL, snapshots repo) and dependency version. |
Files not reviewed (236)
- example-0.73/ios/Pods/DoubleConversion/LICENSE: Language not supported
- example-0.73/ios/Pods/DoubleConversion/README: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/bignum-dtoa.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/bignum-dtoa.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/bignum.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/bignum.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/cached-powers.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/cached-powers.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/diy-fp.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/diy-fp.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/double-conversion.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/double-conversion.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/fast-dtoa.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/fast-dtoa.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/fixed-dtoa.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/fixed-dtoa.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/ieee.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/strtod.cc: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/strtod.h: Language not supported
- example-0.73/ios/Pods/DoubleConversion/double-conversion/utils.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/bignum-dtoa.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/bignum.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/cached-powers.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/diy-fp.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/double-conversion.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/fast-dtoa.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/fixed-dtoa.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/ieee.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/strtod.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/DoubleConversion/double-conversion/utils.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/FBLazyVector/FBLazyVector/FBLazyIterator.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/FBLazyVector/FBLazyVector/FBLazyVector.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/AtomicHashArray-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/AtomicHashArray.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/AtomicHashMap-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/AtomicHashMap.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/AtomicIntrusiveLinkedList.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/AtomicLinkedList.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/AtomicUnorderedMap.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Benchmark.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/BenchmarkUtil.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Bits.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/CPortability.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/CancellationToken-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/CancellationToken.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Chrono.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ClockGettimeWrappers.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ConcurrentBitSet.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ConcurrentLazy.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ConcurrentSkipList-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ConcurrentSkipList.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ConstexprMath.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ConstructorCallbackList.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Conv.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/CppAttributes.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/CpuId.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/DefaultKeepAliveExecutor.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Demangle.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/DiscriminatedPtr.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/DynamicConverter.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Exception.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ExceptionString.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ExceptionWrapper-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ExceptionWrapper.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Executor.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Expected.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FBString.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FBVector.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/File.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FileUtil.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Fingerprint.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FixedString.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FollyMemcpy.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FollyMemset.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Format-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Format.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FormatArg.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/FormatTraits.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Function.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/GLog.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/GroupVarint.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Hash.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/IPAddress.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/IPAddressException.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/IPAddressV4.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/IPAddressV6.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Indestructible.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/IndexedMemPool.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/IntrusiveList.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Lazy.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Likely.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MPMCPipeline.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MPMCQueue.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MacAddress.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MapUtil.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Math.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MaybeManagedPtr.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Memory.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MicroLock.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MicroSpinLock.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/MoveWrapper.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ObserverContainer.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Optional.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Overload.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/PackedSyncPtr.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Padded.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Poly-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Poly.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/PolyException.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Portability.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Preprocessor.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ProducerConsumerQueue.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/RWSpinLock.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Random-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Random.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Range.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Replaceable.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ScopeGuard.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/SharedMutex.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Singleton-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Singleton.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/SingletonThreadLocal.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/SocketAddress.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/SpinLock.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/String-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/String.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Subprocess.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Synchronized.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/SynchronizedPtr.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ThreadCachedInt.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/ThreadLocal.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/TimeoutQueue.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/TokenBucket.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Traits.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Try-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Try.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/UTF8String.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Unicode.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Unit.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Uri-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Uri.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Utility.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/Varint.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/VirtualExecutor.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/Contains.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/FindFixed.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/Ignore.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/Movemask.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/detail/ContainsImpl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/detail/SimdAnyOf.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/detail/SimdForEach.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/detail/SimdPlatform.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/detail/Traits.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/algorithm/simd/detail/UnrollUtils.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/base64.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/chrono/Clock.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/chrono/Conv.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/chrono/Hardware.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/concurrency/CacheLocality.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Access.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Array.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/BitIterator.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Enumerate.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/EvictingCacheMap.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/F14Map-fwd.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/F14Map.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/F14Set-fwd.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/F14Set.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/FBVector.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Foreach-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Foreach.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/HeterogeneousAccess-fwd.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/HeterogeneousAccess.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/IntrusiveHeap.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/IntrusiveList.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Iterator.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/MapUtil.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Merge.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/RegexMatchCache.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/Reserve.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/SparseByteSet.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/View.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/WeightedEvictingCacheMap.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/BitIteratorDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/F14Defaults.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/F14IntrinsicsAvailability.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/F14MapFallback.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/F14Mask.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/F14Policy.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/F14SetFallback.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/F14Table.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/Util.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/detail/tape_detail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/heap_vector_types.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/range_traits.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/small_vector.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/sorted_vector_types.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/span.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/container/tape.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/AsyncTrace.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/AtomicHashUtils.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/AtomicUnorderedMapUtils.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/DiscriminatedPtrDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/FileUtilDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/FileUtilVectorDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/FingerprintPolynomial.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/Futex-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/Futex.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/GroupVarintDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/IPAddress.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/IPAddressSource.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/Iterators.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/MPMCPipelineDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/MemoryIdler.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/PerfScoped.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/PolyDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/RangeCommon.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/RangeSse42.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/SimpleSimdStringUtils.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/SimpleSimdStringUtilsImpl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/Singleton.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/SlowFingerprint.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/SocketFastOpen.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/SplitStringSimd.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/SplitStringSimdImpl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/Sse.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/StaticSingletonManager.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/ThreadLocalDetail.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/TrapOnAvx512.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/TurnSequencer.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/TypeList.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/UniqueInstance.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/detail/thread_local_globals.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/dynamic-inl.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/dynamic.h: Language not supported
- example-0.73/ios/Pods/Headers/Private/RCT-Folly/folly/functional/ApplyTuple.h: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
example-0.73/ios/MovableInkExample/MovableInkExample.entitlements
Outdated
Show resolved
Hide resolved
example-0.73/android/app/src/main/java/com/movableink/app/MainApplication.kt
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 109 out of 161 changed files in this pull request and generated 9 comments.
Files not reviewed (1)
- example-0.83/ios/MovableInkExample.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+131
to
+132
| // val map: Map<String, String> = properties.toHashMap().mapValues { it.value.toString() } | ||
| // MIClient.handlePushNotificationOpened(map) |
There was a problem hiding this comment.
handlePushNotificationOpenedWithContent is annotated with @ReactMethod but the body is commented out, so notifications opened in the example apps won’t be forwarded to the MovableInk SDK. Please convert the ReadableMap into the structure expected by MIClient.handlePushNotificationOpened(...) and invoke it (or remove the JS API until implemented).
Suggested change
| // val map: Map<String, String> = properties.toHashMap().mapValues { it.value.toString() } | |
| // MIClient.handlePushNotificationOpened(map) | |
| val map: Map<String, String> = properties.toHashMap().mapValues { it.value.toString() } | |
| MIClient.handlePushNotificationOpened(map) |
Contributor
Author
There was a problem hiding this comment.
This will be enabled when we go to release this - since the only build that has this is a snapshot.
Comment on lines
19
to
24
| # Enable when testing local pod | ||
| # s.dependency "MovableInk" | ||
| s.dependency "MovableInk" | ||
|
|
||
| # Disable when testing local pod | ||
| s.dependency "MovableInk", "2.2.0" | ||
| # s.dependency "MovableInk", "2.3.0" | ||
|
|
There was a problem hiding this comment.
s.dependency "MovableInk" is unpinned (and the comments around “Enable/Disable when testing local pod” appear inverted). For a library podspec this can lead to unexpected upstream breakages and may desync with Android (which is pinned to inked 2.3.0). Consider pinning MovableInk to the intended version (e.g., 2.3.0) and adjusting the local-testing toggle comments accordingly.
Contributor
Author
There was a problem hiding this comment.
Not an issue, these will be updated when we push a release
Comment on lines
+157
to
+163
| @objc(handlePushNotificationOpenedWithContent:) | ||
| public func handlePushNotificationOpenedWithContent(content: [String: Any]) { | ||
| // Task { @MainActor in | ||
| // guard let content = content as? [String: Sendable] else { return } | ||
| // MIClient.handlePushNotificationOpened(content) | ||
| // } | ||
| } |
There was a problem hiding this comment.
handlePushNotificationOpenedWithContent is exported to React Native, but the implementation is entirely commented out, so JS calls will silently no-op. Please implement the call to MIClient.handlePushNotificationOpened(...) (ensuring it runs on the MainActor and that the payload is converted to the expected Sendable dictionary type) or remove the exported method until it’s supported.
Contributor
Author
There was a problem hiding this comment.
Will also be enabled when we push this release
Comment on lines
+245
to
+247
| handlePushNotificationOpenedWithContent( | ||
| content: Record<string, unknown> | ||
| ): void; |
There was a problem hiding this comment.
The TypeScript API now exposes handlePushNotificationOpenedWithContent, but both native implementations currently no-op (iOS/Android bodies are commented). This creates an API that appears supported but does nothing at runtime; consider either implementing it natively or gating/removing it from the public interface until it’s functional.
Contributor
Author
There was a problem hiding this comment.
Yea this is fine. They are no-oped so the code can compile since we were focusing on updating RN / Gradle and that feature isn't release yet
Comment on lines
+89
to
+101
| @ReactMethod | ||
| fun showInAppMessage(url: String, callback: Callback) { | ||
| val activity = reactApplicationContext.currentActivity | ||
| if (activity == null) { | ||
| Log.d("MISDK", "No current activity") | ||
| callback.invoke("Error: No current activity") | ||
| return | ||
| } | ||
| if (activity !is androidx.lifecycle.LifecycleOwner) { | ||
| Log.d("MISDK", "Activity is not a LifecycleOwner") | ||
| callback.invoke("Error: Activity is not a LifecycleOwner") | ||
| return | ||
| } |
There was a problem hiding this comment.
showInAppMessage now invokes the callback with strings like "Error: ..." when there is no activity / wrong activity type. The JS/TS contract treats the callback argument as a button ID, so passing error strings can make failures look like successful button taps. Consider surfacing failures via a separate error path (e.g., Promise reject, event, or a distinct error callback) and keep this callback reserved for actual button IDs.
Contributor
Author
There was a problem hiding this comment.
This is inline with how the method already handles an exception, it invokes an string with "Error".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new example apps using
React Native 0.79
React Native 0.83
The existing example app (RN 0.73 is removed as 0.73 isn't supported anymore by RN) https://reactnative.dev/versions