This repository was archived by the owner on Jun 25, 2020. It is now read-only.
fixed some broken URLs for fellows 2017 personal websites#388
Closed
drewrwilson wants to merge 1 commit into
Closed
fixed some broken URLs for fellows 2017 personal websites#388drewrwilson wants to merge 1 commit into
drewrwilson wants to merge 1 commit into
Conversation
…ttp was missing in some of the links, resulting in broken links on the webpage
Contributor
|
Hey @drewrwilson sorry I missed this earlier. It looks like the links were already updated in this patch: 9a873e4 After doing a rebase on your patch, we still have this: #393 I'm happy to merge it if it still looks good to you :) |
Contributor
|
Oh wait, looks like |
Contributor
|
Updated it to support the added link, let me know what you think :) |
Contributor
Author
|
Hey @ScottDowne, I just looked at this webpage today to send to someone. It looks like the link for my website is still incorrect :/ My website links to https://www.rishabn.com/ but it should be htts://drewrwilson.com |
Contributor
Author
|
actually, I re-forked the repo and tried to make the change again. I'm closing this pull request because I opened another one with the correct fix: #539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like the http was missing in some of the links, resulting in broken links on the webpage. I updated those links
BIG CONGRATS TO THE NEW FELLOWS!