Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

mainly header and logo changes#424

Open
beccaklam wants to merge 3 commits into
mozilla:masterfrom
beccaklam:buyers-guide-css-changes
Open

mainly header and logo changes#424
beccaklam wants to merge 3 commits into
mozilla:masterfrom
beccaklam:buyers-guide-css-changes

Conversation

@beccaklam
Copy link
Copy Markdown
Contributor

No description provided.

@beccaklam beccaklam requested a review from ScottDowne November 3, 2017 16:10

&.home-link a {
background-image: url(/assets/buyers-guide/thumbnails/home-thumbnail.jpg);
background-image: url(/assets/buyers-guide/thumbnails/01-toys-thumbnail.jpg);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert these changes here?

I think this is due to changes I made after you.

background-image: url(/assets/buyers-guide/thumbnails/06-health-and-exercise-thumbnail.jpg);
}
&.why-link a {
background-image: url(/assets/buyers-guide/thumbnails/08-why-we-made-this-guide.jpg);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert these changes here?

I think this is due to changes I made after you.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this worries me a bit, that you may have accidentally reverted other things too.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things that are not immediately obvious.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update these, and take a quick look through these changes and see if anything looks unfamiliar, otherwise I think we'll be good after the one change.

… issue with the first letter in chrome and safar
&.health-excercise-link a {
background-image: url(/assets/buyers-guide/thumbnails/06-health-and-exercise-thumbnail.jpg);
}
&.why-link a {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put these lines back in too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants