Skip to content

Remove Searchfox function search tool #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suhaibmujahid wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −37
Open

Remove Searchfox function search tool #5742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58db074
Remove Searchfox function search tool
suhaibmujahid Feb 23, 2026
c600ea0
Generalize tool reference in review prompt
suhaibmujahid Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bugbug/tools/code_review/prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
**Step 3: Verify and Assess Confidence**
- Use available tools when you need to verify concerns or gather additional context
- Only include comments where you are at least 80% confident the issue is valid
- When uncertain about an issue, use tools like `find_function_definition` or `expand_context` to verify before commenting
- When uncertain about an issue, use available tools to verify before commenting
- Do not suggest issues you cannot verify with available context
**Step 4: Sort and Order Comments**
Expand Down
36 changes: 0 additions & 36 deletions services/mcp/src/bugbug_mcp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
from fastmcp.resources import FileResource
from pydantic import Field

from bugbug import utils
from bugbug.code_search.searchfox_api import FunctionSearchSearchfoxAPI
from bugbug.tools.code_review.prompts import SYSTEM_PROMPT_TEMPLATE
from bugbug.tools.core.platforms.bugzilla import SanitizedBug
from bugbug.tools.core.platforms.phabricator import (
Expand Down Expand Up @@ -57,40 +55,6 @@ async def patch_review(
return system_prompt + "\n\n" + initial_prompt


def get_file(commit_hash, path):
if commit_hash == "main":
commit_hash = "refs/heads/main"

r = utils.get_session("githubusercontent").get(
f"https://raw.githubusercontent.com/mozilla-firefox/firefox/{commit_hash}/{path}",
headers={
"User-Agent": utils.get_user_agent(),
},
)
r.raise_for_status()
return r.text


function_search = FunctionSearchSearchfoxAPI(get_file)


@mcp.tool()
def find_function_definition(
function_name: Annotated[str, "The name of the function to find its definition."],
) -> str:
"""Find the definition of a function in the Firefox codebase using Searchfox."""
functions = function_search.get_function_by_name(
"main",
"n/a", # The file path is not used
function_name,
)

if not functions:
return "Function definition not found."

return functions[0].source


@mcp.resource(
uri="bugzilla://bug/{bug_id}",
name="Bugzilla Bug Content",
Expand Down