Implement whitelist in ExportConfig#978
Open
AnthonyYoManz wants to merge 1 commit intomozilla:mainfrom
Open
Conversation
Author
|
Maybe I've missed it but I could not find where tests for other ExportConfig fields are, so I took the path of least resistance and simply wrote none for this - although I did test 'manually' by writing a separate crate and making sure behaviour was as described in my PR description. With some guidance on where exactly to put such a test I am happy to write it myself, although it might be a little awkward as I am on Windows and the entire test-suite very much does not function on this platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a field
whitelisttoExportConfig, allowing users to specify an exclusive list of items they wish to include in the generated header file. If the field is left empty it is ignored.If excludes or includes are specified, they override the whitelist. For example in the case where we have functions
foo,bar, andbazand our whitelist specifiesfooandbar, then onlyfooandbarwill be included in the output header file. If they add an includebaz, all three functions will be included in the output. If they then add an excludefoo, onlybarandbazwill be included in the output.Closes #484