Skip to content

feat(gql): Migrate fxa-settings from GraphQL to direct auth-client calls #19869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vbudhram wants to merge 1 commit into from
Closed

feat(gql): Migrate fxa-settings from GraphQL to direct auth-client calls #19869

vbudhram wants to merge 1 commit into from

Conversation

@vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Jan 12, 2026 •
edited
Loading

Because

This pull request

  • Adds account-storage.ts for unified localStorage-based account state management
  • Adds useAccountData hook replacing GraphQL queries with direct auth-client calls
  • Adds AccountStateContext for React state management with localStorage sync
  • Adds POST /account/email_bounce_status endpoint to auth-server for email bounce detection
  • Updates content-server account model to handle new localStorage structure
  • Removes GraphQL dependencies from all signin, signup, and settings flows
  • Removes PageMfaGuardWithGqlTest component (no longer needed)

Issue

Closes: TBD

Checklist

  • My commit is GPG signed
  • Tests pass locally (if applicable)
  • Documentation updated (if applicable)
  • RTL rendering verified (if UI changed)

Other Information

How to test:

  1. yarn start and navigate to localhost:3030, create account and login
  2. Verify account data loads (avatar, emails, 2FA status)
  3. Open multiple tabs and verify session sync works

@vbudhram vbudhram force-pushed the gql-removal branch 2 times, most recently from 58b5c95 to c522304 Compare January 14, 2026 14:43
@vbudhram vbudhram self-assigned this Jan 18, 2026
@vbudhram vbudhram force-pushed the gql-removal branch 5 times, most recently from 6f3de4c to 2a0b23c Compare January 20, 2026 20:13
@vbudhram vbudhram changed the title feat(gql): Migrate fxa-settings from GraphQL to direct auth-client calls (WIP) feat(gql): Migrate fxa-settings from GraphQL to direct auth-client calls Jan 20, 2026
@vbudhram vbudhram marked this pull request as ready for review January 20, 2026 20:17
@vbudhram vbudhram requested a review from a team as a code owner January 20, 2026 20:17
@dschom dschom self-requested a review January 21, 2026 00:23
@vbudhram
feat(gql): Migrate fxa-settings from GraphQL to direct auth-client calls
41a40dc 
Add POST /account/metrics_opt endpoint to auth-server and auth-client,
replacing the last direct GraphQL API call in fxa-settings (metricsOpt).
Remove dead GraphQL error handling, config.servers.gql, CSP rules, and
preconnect directives. fxa-settings now has zero runtime dependency on
fxa-graphql-api.
@vbudhram
Copy link
Contributor Author

vbudhram commented Feb 2, 2026

I've split this PR into more reviewable PRs

#19979
#19980
#19981
#19982

Closing this here

@vbudhram vbudhram closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dschom dschom Awaiting requested review from dschom

Assignees

@vbudhram vbudhram

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbudhram