chore(tests): Add Jest to auth-server, convert first set of tests WIP #19993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add jest.setup.js to set FXA_OPENID_UNSAFELY_ALLOW_MISSING_ACTIVE_KEY - Remove inline env var setting from ip-profiling.spec.ts - Configure jest.config.js to use setupFiles This centralizes the test environment configuration and matches the approach used in the auth-local-test-migration branch.
Refactor ip-profiling.spec.ts to use shared mocks from test/mocks.js where possible, reducing code duplication and improving maintainability. - Replace inline mockDB, mockMailer, mockPush, mockGlean, etc. with shared versions from test/mocks.js - Use getRoute helper from test/routes_helpers.js - Keep mockRequest inline due to proxyquire path resolution issues when running tests from lib/routes/ - Reduce file from ~487 lines to ~305 lines (~37% reduction)
Update Jest test result filenames to follow the same naming convention as Mocha test results for consistency in CI artifacts. - jest-unit-results.xml -> fxa-auth-server-jest-unit-results.xml - jest-integration-results.xml -> fxa-auth-server-jest-integration-results.xml - jest-results.xml -> fxa-auth-server-jest-results.xml
…leCI job - Add test-server.ts helper that spawns auth server as child process (avoids Jest ESM module compatibility issues) - Add jest.integration.config.js for remote/integration tests - Add smoke.spec.ts as initial integration test - Add test-integration-jest Nx target and npm script - Add "Integration Test Jest - Servers - Auth" CircleCI job to: - test_pull_request workflow - test_and_deploy_tag workflow - nightly workflow - Add supporting helpers: mailbox.ts, profile-helper.ts - Add documentation in jest-integration-test-learnings.md
Contributor
Author
|
Closing in favor of #19996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.