Skip to content

Fix integer overflow in composition time calculation #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
padenot wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −2
Open

Fix integer overflow in composition time calculation #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions mp4parse/src/unstable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,23 @@ pub fn create_sample_table(

let start_decode = decode_time;

sample.start_composition = CheckedInteger(track_offset_time.0 + start_composition?.0);
sample.end_composition = CheckedInteger(track_offset_time.0 + end_composition?.0);
let start_composition_val: i64 = match start_composition {
Some(sc) => sc.0,
None => return None,
};
let end_composition_val: i64 = match end_composition {
Some(ec) => ec.0,
None => return None,
};

let track_offset: i64 = track_offset_time.0;

sample.start_composition = CheckedInteger(
track_offset.checked_add(start_composition_val)?
);
sample.end_composition = CheckedInteger(
track_offset.checked_add(end_composition_val)?
);
sample.start_decode = CheckedInteger(start_decode.0);
}

Expand Down