Skip to content

Remove inline eslint globals in configs #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janbrasna wants to merge 4 commits into
base: main
Choose a base branch
from
+0 −8
Open

Remove inline eslint globals in configs #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0287e8
Remove docs/build eslint globals
janbrasna Feb 28, 2026
401f8f9
Remove docs/static eslint globals
janbrasna Feb 28, 2026
53bab62
Remove package/build eslint globals
janbrasna Feb 28, 2026
426516b
Remove package/static eslint globals
janbrasna Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions webpack.docs.build.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/

/* eslint-env node, commonjs, es2017 */

const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const RemoveEmptyScriptsPlugin = require('webpack-remove-empty-scripts');
Expand Down
2 changes: 0 additions & 2 deletions webpack.docs.static.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/

/* eslint-env node, commonjs, es2017 */

const CopyPlugin = require('copy-webpack-plugin');
const path = require('path');
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
Expand Down
2 changes: 0 additions & 2 deletions webpack.package.build.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/

/* eslint-env node, commonjs, es2017 */

const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const RemoveEmptyScriptsPlugin = require('webpack-remove-empty-scripts');
Expand Down
2 changes: 0 additions & 2 deletions webpack.package.static.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/

/* eslint-env node, commonjs, es2017 */

const CopyPlugin = require('copy-webpack-plugin');
const path = require('path');
Comment on lines -7 to 8
Copy link
Contributor Author

@janbrasna janbrasna Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting the new globals are defined slightly differently:

protocol/eslint.config.js

Lines 124 to 132 in d20837b

'webpack.package.build.config.js',
'webpack.package.static.config.js',
'webpack.test.config.js'
],
languageOptions: {
ecmaVersion: 'latest',
globals: {
...globals.node,
...globals.commonjs

const { CleanWebpackPlugin } = require('clean-webpack-plugin');
Expand Down