Fix filter not preserved when building on a ghost & Fix copying settings from existing empty chest, bump v1.0.5#2
Open
Alexamakans wants to merge 3 commits intompcomplete:masterfrom
Conversation
Alexamakans
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no prior Factorio mod writing experience, meaning there is likely a better way to do this.
I figured I would provide the code for my fix as a guide for fixing it properly.
I didn't notice any changes in behavior after removing the rotation/pre-build event stuff, but if it should be kept in I can remove it from the PR.
Closes #1
Closes #3