Skip to content

Modify drainSendRecv() for easy debugging #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gc00 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Modify drainSendRecv() for easy debugging #302

gc00 wants to merge 2 commits into from

Conversation

@gc00
Copy link
Collaborator

@gc00 gc00 commented Mar 1, 2023

This PR should not be pushed in. It's here only to make debugging easy. By making this a PR, it's easy to find, and the Jenkins test will help get rid of minor bugs in the code.

See the generous comments in drainSendRecv() for an explanation of why this makes debugging easy. In summary:

  • STAGE 1: Test and complete requests, only.
  • STAGE 2: If all requests that can be completed have been completed, it should now be safe to drain messages to the MANA internal buffer.

@gc00 gc00 requested review from tarunsmalviya and xuyao0127 March 1, 2023 21:35
@gc00 gc00 force-pushed the bit-for-bit-debug branch from 2846c51 to 4777f51 Compare March 1, 2023 21:42
@gc00 gc00 force-pushed the bit-for-bit-debug branch from 4777f51 to e746c97 Compare March 1, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuyao0127 xuyao0127 Awaiting requested review from xuyao0127

@tarunsmalviya tarunsmalviya Awaiting requested review from tarunsmalviya

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gc00