feat: add sheet command to dnd room#311
Merged
Merged
Conversation
Upsert takes CharacterSheetParams like the game-model upserts, the conflict clause uses EXCLUDED columns, and the migration gains DB CHECK length constraints matching the app-side limits.
resolve_sheet reuses resolve_profile_target for the username branch, save_sheet_task extracts a named save_sheet helper matching sibling tasks, and the /sheet dispatch drops a defensive nesting level to match the /cup idiom.
Username, system, feed-url, and bio editing now delegate to common/textarea_input, deleting the per-field delegate methods, limited-insert helpers, and duplicated char-count functions. Behavior deltas: ctrl-u clear is undoable (select-all + cut instead of textarea reset); feed-url gains word jump/delete keys. Link/delete account dialogs keep bespoke handlers (step machines with side effects, not plain text editing).
Main claimed 070 for the sshattrick reward seed while this branch was in flight.
ricott1
force-pushed
the
feat/sheet-command
branch
from
50dd465 to
6214719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sheet command to dnd room. On the way I also refactored some common functions for modals