Voice: status icons + live speaking indicator#325
Open
hardlygospel wants to merge 1 commit into
Open
Conversation
The voice roster previously showed each participant as '@name <word>' with the status as plain text. Give each row a status icon (green dot speaking, white dot listening, muted-speaker, muted-bell deafened) and make a speaking user's name pop green+bold as a live indicator. The controls line gains matching icons (mic / headphones / enter). Presence is factored into a small priority-ordered enum (deafened > muted > speaking > listening) with unit tests covering the precedence and icon/label distinctness. Signed-off-by: Tony Hosaroygard <tasmaniamate@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The voice roster used to show each participant as
@name <word>with the status as plain text, and the controls line was text-only. This adds status icons and a live speaking indicator:🟢 live · ⏎ leave · 🎤 u mic · 🎧 d deafen.How
Presence is factored into a small priority-ordered enum (
deafened > muted > speaking > listening) withicon()/label()/color(), so the roster and the controls line stay in sync and the logic is unit-testable.Tests
Two new unit tests cover the presence precedence and that every state has a distinct icon and label.
cargo test -p late-ssh --lib voiceis green; no new clippy warnings.UI-only change, contained to
voice/ui.rs. No service, schema, or config changes.Thanks 🙏